Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit on installer failure #40

Closed
tahg opened this issue Sep 10, 2021 · 0 comments
Closed

Exit on installer failure #40

tahg opened this issue Sep 10, 2021 · 0 comments

Comments

@tahg
Copy link

tahg commented Sep 10, 2021

In the case ServerStarter runs into issues while startup up, it should exit. On Windows, adding pause would help as well. On Linux it's less likely to be necessary, as having a console that closes when finished is rarer.

In my case, the installer failed to delete a directory because I accidently had a file open, but there any error during install could cause problems. As it stands, ServerStarter will continue to actually start the server even if there was an error, which can lead to missing mods or config, or world corruption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant