Merge pull request #294 from kalvdans/small-buffers

Correct the return code on too small compression buffers
Blosc · May 10, 2020 · 4f16db5 · 4f16db5
2 parents ed7ad70 + a328c4f
commit 4f16db5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/blosc/blosc.c b/blosc/blosc.c
@@ -1090,9 +1090,7 @@ static int initialize_context_compression(struct blosc_context* context,
     return -1;
   }
   if (destsize < BLOSC_MAX_OVERHEAD) {
-    fprintf(stderr, "Output buffer size should be larger than %d bytes\n",
-            BLOSC_MAX_OVERHEAD);
-    return -1;
+    return 0;
   }
 
   /* Compression level */

diff --git a/tests/test_maxout.c b/tests/test_maxout.c
@@ -105,17 +105,17 @@ static const char *test_maxout_great_memcpy(void) {
 static const char *test_max_overhead(void) {
   blosc_init();
   cbytes = blosc_compress(0, doshuffle, typesize, size, src, dest, BLOSC_MAX_OVERHEAD - 1);
-  mu_assert("ERROR: cbytes is not correct", cbytes < 0);
+  mu_assert("ERROR: cbytes is not correct", cbytes == 0);
   blosc_destroy();
 
   blosc_init();
   cbytes = blosc_compress(0, doshuffle, typesize, size, src, dest, BLOSC_MAX_OVERHEAD - 2);
-  mu_assert("ERROR: cbytes is not correct", cbytes < 0);
+  mu_assert("ERROR: cbytes is not correct", cbytes == 0);
   blosc_destroy();
 
   blosc_init();
   cbytes = blosc_compress(0, doshuffle, typesize, size, src, dest, 0);
-  mu_assert("ERROR: cbytes is not correct", cbytes < 0);
+  mu_assert("ERROR: cbytes is not correct", cbytes == 0);
   blosc_destroy();
 
   return 0;