Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the return code on too small compression buffers #294

Merged
merged 2 commits into from
May 10, 2020
Merged

Correct the return code on too small compression buffers #294

merged 2 commits into from
May 10, 2020

Conversation

kalvdans
Copy link
Contributor

@kalvdans kalvdans commented May 8, 2020

Fixes #293

@nmoinvaz
Copy link
Member

nmoinvaz commented May 8, 2020

Is it possible to include a cmake test for this?

@kalvdans
Copy link
Contributor Author

kalvdans commented May 8, 2020

Is it possible to include a cmake test for this?

I modified the existing tests. Excellent test suite by the way!

@FrancescAlted
Copy link
Member

LGTM. BTW, the previous error condition (sourcesize > BLOSC_MAX_BUFFERSIZE) should return a 0 too. Will do later on.

@FrancescAlted FrancescAlted merged commit 4f16db5 into Blosc:master May 10, 2020
@FrancescAlted
Copy link
Member

The new check sourcesize > BLOSC_MAX_BUFFERSIZE as well as initial support for BLOSC_WARN envvar is implemented in 403d50c.

@kalvdans
Copy link
Contributor Author

Thanks Francesc for the quick response and fix! :)

FrancescAlted added a commit that referenced this pull request Jun 5, 2020
@FrancescAlted
Add the new return code for cannot compress status (#294)
8131eb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spam on stderr: Output buffer size should be larger than 16 bytes
3 participants
@kalvdans @nmoinvaz @FrancescAlted