Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tsodyksmarkramstp example #458

Merged
merged 1 commit into from
May 10, 2023
Merged

Fix tsodyksmarkramstp example #458

merged 1 commit into from
May 10, 2023

Conversation

AurelienJaquier
Copy link
Collaborator

Solves Issue #457

@AurelienJaquier AurelienJaquier self-assigned this May 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2023 •
edited
Loading

Codecov Report

Merging #458 (0b1675d) into master (890c14e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   87.43%   87.43%           
=======================================
  Files          50       50           
  Lines        4323     4323           
=======================================
  Hits         3780     3780           
  Misses        543      543

@AurelienJaquier AurelienJaquier requested a review from DrTaDa May 10, 2023 07:35
DrTaDa
DrTaDa approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@DrTaDa DrTaDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the method is called init_simulator_and_evaluate_with_lists but it does not actually init a simulator ? haha

@AurelienJaquier
Copy link
Collaborator Author

Yeah. it is called during optimisation, assuming the evaluator is a Cellevaluator, which has a simulator and this method. So for the other evaluators, we have to create this function, even if it is just calling evaluate_with_lists.

@AurelienJaquier AurelienJaquier merged commit 3a28ef9 into master May 10, 2023
@AurelienJaquier AurelienJaquier deleted the fix-tmevaluator-example branch May 10, 2023 07:52
@AurelienJaquier AurelienJaquier mentioned this pull request May 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrTaDa DrTaDa DrTaDa approved these changes

Assignees

@AurelienJaquier AurelienJaquier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AurelienJaquier @codecov-commenter @DrTaDa