Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Consolidate ini/config parsing #49

Open
erichelgeson opened this issue Jul 3, 2023 · 0 comments
Open

Chore: Consolidate ini/config parsing #49

erichelgeson opened this issue Jul 3, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@erichelgeson
Copy link
Contributor

Config is parsed all over the place which leads to bugs and duplicated code. It is hard coded to one file which makes it inflexible.

We should be able to:

  • Abstract away the file it's reading the config from
  • Allow updates to config values
    • This is more complex now that there's a caching layer
  • Have one way to get the most correct value for a key (See Fixes hard coded block sizes in multiple locations. #47)
    • ini scsi id section - take this no matter what, user must know more than we do
    • ini scsi global section - take this if not set in the id section.
    • File name - take this if not set in the ini
    • Runtime detection if applicable
    • Sane default
  • Move config keys to own file and document there
    • Have process parse this file and update ini.bluescsi.com and the wiki automatically
@erichelgeson erichelgeson added the enhancement New feature or request label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant