Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screenshot change #21

Merged
merged 10 commits into from
Oct 8, 2022
Merged

screenshot change #21

merged 10 commits into from
Oct 8, 2022

Conversation

Ilithy
Copy link
Contributor

@Ilithy Ilithy commented Oct 8, 2022

Proposed screenshot change.

  • I added the translation engine selection screen (image option-1.png and option-2.png).
  • I did not add the history screen (we can clearly see the option on the captures mentioned above)
  • I added the files (trying to follow the naming style) in the folder fastlane/metadata/android/en-US/images/phoneScreenshots/
  • I modified the Readme to display the new captures (in addition to the "old ones")

If you don't like it, feel free to refuse it.
Thanks

@Bnyro
Copy link
Member

Bnyro commented Oct 8, 2022

The new screenshots look good to me, thanks <3
It seems that you've been naming the screenshots option-1 and option-2 while referencing them with options-1 and options-2 in the README, therefore they don't load properly in the Readme yet :)

README.md Outdated Show resolved Hide resolved
@Ilithy
Copy link
Contributor Author

Ilithy commented Oct 8, 2022

The new screenshots look good to me, thanks <3 It seems that you've been naming the screenshots option-1 and option-2 while referencing them with options-1 and options-2 in the README, therefore they don't load properly in the Readme yet :)

--'
Indeed, a mistake on my part, my apologies and thank you for the correction

PS: On the "about" screenshot, I removed the version number, to avoid having to modify it unnecessarily at each new update of the application

Ilithy and others added 2 commits October 8, 2022 12:03
Co-authored-by: Bnyro <82752168+Bnyro@users.noreply.github.com>
@Bnyro Bnyro merged commit c7ce8ed into you-apps:master Oct 8, 2022
@Bnyro
Copy link
Member

Bnyro commented Oct 8, 2022

Indeed, a mistake on my part, my apologies and thank you for the correction

No worries, happens to the best of us :)

PS: On the "about" screenshot, I removed the version number, to avoid having to modify it unnecessarily at each new update of the application

That's indeed a good idea, thank you for your efforts <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants