Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation proposals #23

Merged
merged 6 commits into from
Oct 9, 2022
Merged

Automation proposals #23

merged 6 commits into from
Oct 9, 2022

Conversation

Ilithy
Copy link
Contributor

@Ilithy Ilithy commented Oct 8, 2022

Proposal to add several Automation Actions:

  • validate store files -> Verifies that the description files do not exceed a maximum number of characters (defined by Play store policy)

  • codacy -> This workflow checks out code, performs a Codacy security scan

  • labeler -> Workflow to automate the labeling of pull requests.
    It will be necessary to add the corresponding labels

  • validate gradle build test -> This actions validates the gradle files and runs a build test to ensure the app is not corrupted.

As before, if this does not suit you, close the PR

Ilithy added 5 commits October 8, 2022 21:01
* Create validate-gradle-build-test.yml

* Create codacy.yml

* Create labeler.yml

* Create labeler.yml

* Create validate-store-files.yml
@Bnyro
Copy link
Member

Bnyro commented Oct 9, 2022

Hey, thanks for your pull request!
I just a few quick question about how the labeler works since I've never used something like that:

  • What kind of labels do I need to create? How does the labeler detect which labels to add to a PR?
  • Which permissions does the GITHUB_TOKEN need access/privileges for?

Thanks in advance for all your efforts :)

@Ilithy
Copy link
Contributor Author

Ilithy commented Oct 9, 2022

What kind of labels do I need to create?

Translation, Automation, Github, Core, Fastlane, Gradle wrapper

Necessary for the labeler to work

How does the labeler detect which labels to add to a PR?

It performs a triage action (using actions/labeler@v4)
the labeler file in the .github folder allows this sorting by providing the folders/files it needs to monitor (it checks if there have been modifications) and labels the PR according to the parameter that defines it.
(for example of how it works, see my PR here: Ilithy#4, label automatically)

Which permissions does the GITHUB_TOKEN need access/privileges for?

Reading of the repository files (to check if there are any modifications) and writing (only to label the PR)

@Bnyro
Copy link
Member

Bnyro commented Oct 9, 2022

Alright, perfect, thank you <3
I'll set up the labels as well as the GITHUB_TOKEN asap and merge it then :)

@Bnyro Bnyro merged commit 3c3f9f7 into you-apps:master Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants