Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux: the implementation is now thread-safe #172

Merged
merged 1 commit into from
Jun 28, 2020

Conversation

BoboTiG
Copy link
Owner

@BoboTiG BoboTiG commented Jun 28, 2020

Changes proposed in this PR

It is very important to keep up to date tests and documentation.

  • Tests added/updated
  • Documentation updated

Is your code right?

  • PEP8 compliant
  • flake8 passed

@BoboTiG BoboTiG force-pushed the fix-169-linux-thread-safety branch from 1f5aa78 to adc8402 Compare June 28, 2020 16:07
@sourcery-ai
Copy link

sourcery-ai bot commented Jun 28, 2020

Sourcery Code Quality Report (beta)

✅ Merging this PR will increase code quality in the affected files by 0.2 out of 10.

Before After Change
Quality 7.98 8.18 0.2
Complexity 1.53 1.29 -0.23
Method Length 95.57 84.41 -11.16
Lines 560 629 69
Changed files Quality Before Quality After Quality Change
mss/linux.py 7.3 7.83 0.53 ⬆️
mss/tests/test_implementation.py 8.59 8.53 -0.06 ⬇️

Here are some functions in these files that still need a tune-up:

File Function Quality Recommendation
mss/tests/test_implementation.py test_entry_point 5.19 Split out functionality
mss/linux.py MSS._set_cfunctions 5.85 Split out functionality

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it via email or our Gitter!

@BoboTiG BoboTiG merged commit 59c2259 into master Jun 28, 2020
@BoboTiG BoboTiG deleted the fix-169-linux-thread-safety branch June 28, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grabbing screen concurrently crashes with Linux.
1 participant