Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support upper and mixed case file extensions #99

Closed
kehoecj opened this issue Dec 1, 2023 · 1 comment
Closed

Add support upper and mixed case file extensions #99

kehoecj opened this issue Dec 1, 2023 · 1 comment
Labels
good first issue Good for newcomers has-pr This issue has an associated PR help wanted Extra attention is needed validator-core Issues that relate to the core validator functionality

Comments

@kehoecj
Copy link
Collaborator

kehoecj commented Dec 1, 2023

Source

Can the finder code be more tolerant to unofficial extensions(such as .TOML)? I know that the spec says that the extension should be .toml, but some of the projects I am currently working on did use unofficial extensions.

Description

Update the config-file-validator to support upper and mixed case file extensions for each supported file type. The file extension comparision in the fsfinder.go needs to be updated to compare the lowercase version of the file extension found during the filepath.WalkDir execution instead of the raw filename.

The unit tests will need to be updated to provide upper and mixed case files to support this change.
@kehoecj kehoecj added good first issue Good for newcomers help wanted Extra attention is needed validator-core Issues that relate to the core validator functionality labels Dec 1, 2023
@kehoecj kehoecj mentioned this issue Dec 1, 2023
Open
@iyoshiha iyoshiha mentioned this issue Dec 3, 2023
Merged
@kehoecj kehoecj added the has-pr This issue has an associated PR label Dec 5, 2023
@kehoecj
Copy link
Collaborator Author

kehoecj commented Dec 11, 2023

Closed by #102

@kehoecj kehoecj closed this as completed Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers has-pr This issue has an associated PR help wanted Extra attention is needed validator-core Issues that relate to the core validator functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kehoecj