Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking upstream Workbox CRA config and our react-app-rewired dependencies #2

Open
boomskats opened this issue Jun 19, 2020 · 0 comments
Open

Tracking upstream Workbox CRA config and our react-app-rewired dependencies #2

boomskats opened this issue Jun 19, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@boomskats
Copy link
Contributor

Opening this issue to track that upstream dependency and wait for the PR at /facebook/create-react-app #5369 to be merged.

Currently we're using react-app-rewired and react-app-rewire-workbox to enable customisation of our service worker config, so we can control the offline mode, update and caching behaviours without ejecting. This won't be needed once that PR is merged and we can get rid of the dependency on react-app-rewired.
@boomskats boomskats added the enhancement New feature or request label Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@boomskats