Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated sound library do not play as expected on comma2 #175

Open
frobichaud opened this issue Sep 28, 2022 · 1 comment
Open

Updated sound library do not play as expected on comma2 #175

frobichaud opened this issue Sep 28, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@frobichaud
Copy link
Contributor

Describe the bug

Branch: tesla_unity_dev
Commit SHA: c204f6e
Video of the issue
https://photos.app.goo.gl/34JTUhttqRmXR7KM7

The new sound library doesn't sound like the .wav when played on a computer.

Repeatable steps:

  • turn off / off openpilot on a comma2 device

What hardware does this issue affect?

comma two

Provide a route where the issue occurs

N/A

openpilot version

0.8.13-c204f6e

Additional info

No response

@frobichaud frobichaud added the bug Something isn't working label Sep 28, 2022
@frobichaud
Copy link
Contributor Author

Maybe the new audio files need to be resampled to 48kHz

Original audio file:

francis@MacBook-Air ~ % mediainfo selfdrive_assets_sounds_engage\ \(1\).wav
General
Complete name                            : selfdrive_assets_sounds_engage (1).wav
Format                                   : Wave
File size                                : 61.6 KiB
Duration                                 : 657 ms
Overall bit rate mode                    : Constant
Overall bit rate                         : 769 kb/s

Audio
Format                                   : PCM
Format settings                          : Little / Signed
Codec ID                                 : 1
Duration                                 : 657 ms
Bit rate mode                            : Constant
Bit rate                                 : 768 kb/s
Channel(s)                               : 1 channel
Sampling rate                            : 48.0 kHz
Bit depth                                : 16 bits
Stream size                              : 61.6 KiB (100%)

New audio file:

francis@MacBook-Air ~ % mediainfo selfdrive_assets_sounds_engage.wav
General
Complete name                            : selfdrive_assets_sounds_engage.wav
Format                                   : Wave
File size                                : 158 KiB
Duration                                 : 904 ms
Overall bit rate mode                    : Constant
Overall bit rate                         : 1 436 kb/s

Audio
Format                                   : PCM
Format settings                          : Little / Signed
Codec ID                                 : 1
Duration                                 : 904 ms
Bit rate mode                            : Constant
Bit rate                                 : 1 411.2 kb/s
Channel(s)                               : 2 channels
Sampling rate                            : 44.1 kHz
Bit depth                                : 16 bits
Stream size                              : 156 KiB (98%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant