Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Custom Theme JS incorrectly escaping single and double quotes #199

Closed
jessecowens opened this issue May 27, 2020 · 0 comments · Fixed by #213
Closed

[Bug] Custom Theme JS incorrectly escaping single and double quotes #199

jessecowens opened this issue May 27, 2020 · 0 comments · Fixed by #213
Labels
bug General bug issues
Projects
Bug Backlog BACKLOG

Comments

@jessecowens
Copy link
Member

jessecowens commented May 27, 2020 •
edited
Loading

Describe the bug
When using the Custom Theme JS editor, single and double quotation marks are escaped as \' and " respectively. This causes a console error Uncaught SyntaxError: Invalid or unexpected token and invalidates the custom script.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Customize -> CSS/JS Editor
  2. Enter in any valid jQuery statement and publish
  3. View page source, and see the incorrect markup.

Expected behavior
Quotation marks should be output in markup literally without being escaped.

Screenshots
escaped-quotes
valid-javascript
js-error
@jamesros161 jamesros161 added the bug General bug issues label May 28, 2020
@jamesros161 jamesros161 added this to Needs triage in Bug Backlog via automation May 28, 2020
@jamesros161 jamesros161 added this to Backlog in BACKLOG May 28, 2020
@jamesros161 jamesros161 moved this from Backlog to Next in BACKLOG May 28, 2020
@jamesros161 jamesros161 moved this from Next to Now in BACKLOG May 28, 2020
@jamesros161 jamesros161 moved this from Now to Next in BACKLOG May 28, 2020
@jamesros161 jamesros161 moved this from Next to Now in BACKLOG Jun 8, 2020
@jamesros161 jamesros161 moved this from Now to Next in BACKLOG Jun 8, 2020
@jamesros161 jamesros161 moved this from Next to Now in BACKLOG Jun 10, 2020
@jamesros161 jamesros161 mentioned this issue Jun 10, 2020
Merged
Bug Backlog automation moved this from Needs triage to Closed Jun 11, 2020
BACKLOG automation moved this from Now to Done Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug General bug issues
Projects
BACKLOG
  
Done
Bug Backlog
  
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed esc_js() from custom_js_output() BoldGrid/boldgrid-theme-framework
2 participants
@jessecowens @jamesros161