Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Template 'Page Title' does not use calculated Heading Font Size values. #553

Closed
jamesros161 opened this issue Dec 9, 2021 · 3 comments
Labels
bug General bug issues
Milestone

Comments

@jamesros161
Copy link
Contributor

The .bgc-heading.bgc-page-title class is getting it's font-size from the bgtfw_heading_font_size control directly, rather than getting the calculated value. This causes them to have the h5 font size, rather than the font size calculated for an h1.

This may be due to the fact that the .bgc-heading.bgc-page-title doesn't contain an 'h' class. Consider adding .h5 or .h1 to the class depending on what heading size is chosen.

@jamesros161 jamesros161 added this to the Stable milestone Dec 21, 2021
@jamesros161 jamesros161 added the bug General bug issues label Dec 21, 2021
@nicolepaschen
Copy link
Member

When I change the Heading Typography, it also changes the Site Title in a Custom Page Header. When I hover over the Site Title the text goes smaller. If I close the Customizer the Site Title goes back to the normal size:

heading-controls-site-title

Site Title might need it's own responsive controls here:
image

@nicolepaschen
Copy link
Member

Also see #557

@nicolepaschen
Copy link
Member

I have the Site Title in a footer layout - when I hover on it another font appears:
site-title-glitch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug General bug issues
Projects
None yet
Development

No branches or pull requests

2 participants