Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Menu Direction options. #313

Closed
jamesros161 opened this issue Dec 6, 2021 · 4 comments · Fixed by #312 or #315
Closed

Add Menu Direction options. #313

jamesros161 opened this issue Dec 6, 2021 · 4 comments · Fixed by #312 or #315
Labels
Feature Request Niche Websites
Milestone
Stable

Comments

@jamesros161
Copy link
Collaborator

Footer menus are usually vertical. The only way to have vertical menus right now is to use the standard WP Navigation Menu widget, as the one we made for Custom Page Headers only goes horizontal.

Can we add a toggle to the Navigation Menu widget we made for it to be vertical?
How else can I add a horizontal menu to a footer but still have font color / size / family controls?
@jamesros161 jamesros161 linked a pull request Dec 6, 2021 that will close this issue
add menu direction control #312
Merged
@jamesros161 jamesros161 mentioned this issue Dec 7, 2021
Merged
@jamesros161 jamesros161 linked a pull request Dec 7, 2021 that will close this issue
Add menu direction controls #315
Merged
@jamesros161 jamesros161 added this to the Stable milestone Dec 9, 2021
@nicolepaschen
Copy link
Member

RC1 - please update icon for vertical to be up and down

vertical-icon-up-down

@nicolepaschen
Copy link
Member

RC1 - with dropdown menus the first element is too far to the left:

dropdown-first-element

@nicolepaschen
Copy link
Member

RC1 - vertical menus do not line up - links after the first are indented
vertical-menu-alignment

@jamesros161 jamesros161 mentioned this issue Dec 16, 2021
Merged
@nicolepaschen
Copy link
Member

nicolepaschen commented Dec 17, 2021 •
edited
Loading

I didn't start with inspirations or starter content. This is in the standard header nothing custom. I made a menu and the spacing between the items isn't even - the 2nd item is closer than it should be to the 1st. The hover effect helps show it:

menu-2nd-item

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Niche Websites
Projects
None yet
Milestone
Stable
2 participants
@nicolepaschen @jamesros161