Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable the automiatic deletion of un-referenced attach… #3225

Merged
merged 8 commits into from
Aug 30, 2019
Merged

Add option to disable the automiatic deletion of un-referenced attach… #3225

merged 8 commits into from
Aug 30, 2019

Conversation

ehhc
Copy link
Contributor

@ehhc ehhc commented Aug 26, 2019

…ments -> might fix #3203

@Rokt33r what do you think about this?

@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Aug 26, 2019
@ZeroX-DG
Copy link
Member

@ehhc , in this case, do the user have anyway to know how many unused attachments that he/she has? And is there a way for the users to easily remove all of them to save space?

@ehhc
Copy link
Contributor Author

ehhc commented Aug 27, 2019

hi @ZeroX-DG,
no there is no way to know how many unused attachments exist. furthermore there is no (easy) way to delete them.
I don't have the time (and don't want to) implement that..
If they don't want attachments to be deleted, they have to do it manually in my opinion..

@ZeroX-DG
Copy link
Member

I'll try to find a way to get unused attachments and make a button to clean those things up and submit a PR to your PR.

@ehhc
Copy link
Contributor Author

ehhc commented Aug 28, 2019

@ZeroX-DG @Rokt33r i've merged the changes into my PR

@ZeroX-DG ZeroX-DG added needs extra review 🔎 Pull request requires review from an additional reviewer. and removed awaiting review ❇️ Pull request is awaiting a review. labels Aug 28, 2019
@ZeroX-DG ZeroX-DG requested a review from Rokt33r August 28, 2019 22:17
@ZeroX-DG
Copy link
Member

@Rokt33r I mark this as need more review because I contributed to this PR too so I can't approve my own code 😄

@Rokt33r Rokt33r removed the needs extra review 🔎 Pull request requires review from an additional reviewer. label Aug 29, 2019
@Rokt33r Rokt33r added this to the v0.13.0 milestone Aug 29, 2019
@Rokt33r
Copy link
Member

Rokt33r commented Aug 29, 2019

@ehhc @ZeroX-DG This pr hasn't passed in CI yet...!

@ZeroX-DG
Copy link
Member

@Rokt33r I missed a small detail and have submitted a PR to fix this. We have to wait for @ehhc to merge it. Sorry for the inconvenience
ehhc#2

@ehhc
Copy link
Contributor Author

ehhc commented Aug 29, 2019

@ZeroX-DG @Rokt33r done

@Rokt33r Rokt33r merged commit 28b8141 into BoostIO:master Aug 30, 2019
@ehhc ehhc deleted the option_for_attachment_delete branch August 30, 2019 06:51
@Flexo013 Flexo013 mentioned this pull request Aug 30, 2019
Closed
@Flexo013 Flexo013 mentioned this pull request Nov 27, 2019
Closed
@mfouet mfouet mentioned this pull request Feb 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rokt33r Rokt33r Awaiting requested review from Rokt33r

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.

Files, Images get deleted automatically after dragging them on to boostnote interface.
4 participants
@ehhc @ZeroX-DG @Rokt33r @Flexo013