Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix preview-window's scroll behavior, #3289 #3294

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Fix preview-window's scroll behavior, #3289 #3294

merged 1 commit into from
Oct 28, 2019

Conversation

hikerpig
Copy link
Contributor

Description

Fixed two issues.

  1. Add a MarkdownPreview::scrollTo to call body.scrollTo instead of window.scrollTo, the implementation is similar to PR 3293, but more thorough.
  2. scrollPastEnd behavior is broken by addf9b9 , add some more style tweak to fix it.

2019-10-21 14 08 26

Issue fixed

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)

@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Oct 21, 2019
ZeroX-DG
ZeroX-DG approved these changes Oct 27, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Oct 27, 2019
@ZeroX-DG ZeroX-DG mentioned this pull request Oct 27, 2019
Closed
@Flexo013 Flexo013 mentioned this pull request Oct 27, 2019
Merged
@Rokt33r Rokt33r modified the milestones: v0.13.0, v0.14.0 Oct 28, 2019
@Rokt33r Rokt33r merged commit 77833ff into BoostIO:master Oct 28, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rokt33r Rokt33r Rokt33r approved these changes

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hikerpig @Rokt33r @ZeroX-DG @Flexo013