Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory leak in OCAlgorithms #5

Closed
yuun opened this issue Jul 6, 2012 · 1 comment
Closed

memory leak in OCAlgorithms #5

yuun opened this issue Jul 6, 2012 · 1 comment

Comments

@yuun
Copy link

yuun commented Jul 6, 2012

Hi,

First I want to thank all the contributors to this great project !
I believe there is a memory leak in the OCAlgorithms.m file raised also by xcode clang analyser.

Line 137 :
// check group if (grouped && [annotation respondsToSelector:@selector(groupTag)]) { if (![clusterAnnotation.groupTag isEqualToString:((id <OCGrouping>)annotation).groupTag]) continue; } // add annotation to the cluster [clusterAnnotation addAnnotation:annotation]; [clusterAnnotation release];

There should be [clusterAnnotation release] before the continue instruction

Thanks again for your great job!

Yunus

@BotiKis
Copy link
Owner

BotiKis commented Jul 6, 2012

Yes, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants