Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review by Abhi Vora #15

Open
abhivora1 opened this issue Nov 16, 2017 · 0 comments
Open

Code Review by Abhi Vora #15

abhivora1 opened this issue Nov 16, 2017 · 0 comments

Comments

@abhivora1
Copy link

  1. The start of any outsider into your Github Repo is your ReadME file and y'all have done a great job in that regard. The File is very well organized and has detailed description on how to access this repository . This also would help others who would like to contribute to this project.

  2. Coming to The UI i.e. the Webpage, http://medusapys.site/index.html , it is very nicely made. It is user friendly and very accessible . The only issue I had with it, was that when I tried uploading a file to run your application, I get sent to a DeadEnd where I receive a confirmation that my file is uploaded. It would be more useful, if that can redirect me to a page into the Website.

  3. The python files written by y'all seem to be very well maintained. There are comments when required and there is a good use of variable names which makes it easier for outsiders like me to understand your code. The only suggestion I would give is that y'all should run the codes through PEP8 or PYLINT which could make the code look more presentable although that need not be a priority, considering the amount of work to be done.

  4. I do not see a license in the Master Branch of your code. Maybe its a good idea to do so.

  5. The Achieve folder seems some what a mystery to me. There was no Read ME file as well as there were many formats of files, which got me very confused.

  6. MAJOR PROBLEM: In your database directory, I can see your Database credentials, which is not a good idea at all. I Can go at this second and make malicious changes in your DB. Please look into this ASAP.

  7. As we heard Prof. Osama say, try avoiding arbitrary numbers in the code, since it may differ from architecture to architecture.

Finally I would like to say, that y'all have done a good job and keep it up!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant