diff --git a/DEVELOPING.md b/DEVELOPING.md index ca947a47..7e4fc621 100644 --- a/DEVELOPING.md +++ b/DEVELOPING.md @@ -75,7 +75,7 @@ gulp prerelease && cd testbed && npm install -g cordova && cordova platform remo > Validate all features on both `iOS` and `Android` on `device` only (no `simulator` or `TestFlight`) ```sh -cordova build ios && open -a Xcode platforms/ios/Branch\ Testing.xcworkspace; +cordova build ios --developmentTeam="PW4Q8885U7" --device; ``` ```sh diff --git a/src/android/io/branch/BranchSDK.java b/src/android/io/branch/BranchSDK.java index 3cb0085b..feee1b74 100644 --- a/src/android/io/branch/BranchSDK.java +++ b/src/android/io/branch/BranchSDK.java @@ -459,6 +459,9 @@ private BranchLinkProperties createLinkProperties(JSONObject options, JSONObject if (options.has("stage")) { linkProperties.setStage(options.getString("stage")); } + if (options.has("campaign")) { + linkProperties.setCampaign(options.getString("campaign")); + } if (options.has("duration")) { linkProperties.setDuration(options.getInt("duration")); } diff --git a/src/ios/BranchSDK.m b/src/ios/BranchSDK.m index fefd9204..eac046a2 100644 --- a/src/ios/BranchSDK.m +++ b/src/ios/BranchSDK.m @@ -454,6 +454,9 @@ - (void)generateShortUrl:(CDVInvokedUrlCommand*)command else if ([key isEqualToString:@"stage"]) { props.stage = [arg1 objectForKey:key]; } + else if ([key isEqualToString:@"campaign"]) { + props.campaign = [arg1 objectForKey:key]; + } else if ([key isEqualToString:@"alias"]) { props.alias = [arg1 objectForKey:key]; } diff --git a/testbed/www/js.es6/index.js b/testbed/www/js.es6/index.js index b03a6ffc..5558851c 100644 --- a/testbed/www/js.es6/index.js +++ b/testbed/www/js.es6/index.js @@ -182,7 +182,8 @@ function BranchDeepLink() { $ipad_url: "http://www.example.com/ipad", more_custom: "data", even_more_custom: true, - this_is_custom: 41231 + this_is_custom: 41231, + this_is_date: Date.now() }; // needs a universal object diff --git a/testbed/www/js/index.js b/testbed/www/js/index.js index 042c2bf7..0a7d663f 100644 --- a/testbed/www/js/index.js +++ b/testbed/www/js/index.js @@ -184,7 +184,8 @@ function BranchDeepLink() { $ipad_url: "http://www.example.com/ipad", more_custom: "data", even_more_custom: true, - this_is_custom: 41231 + this_is_custom: 41231, + this_is_date: Date.now() }; // needs a universal object diff --git a/www.es6/branch.js b/www.es6/branch.js index dbe2273f..1b550654 100644 --- a/www.es6/branch.js +++ b/www.es6/branch.js @@ -292,6 +292,7 @@ Branch.prototype.createBranchUniversalObject = function(options) { * | feature | String | The link feature | * | alias | String | The link alias | * | channel | String | The link channel | + * | campaign | String | The link campaign | * | stage | String | The link stage | * | duration | Int | The link duration | * -------------------------------------------------- @@ -332,6 +333,7 @@ Branch.prototype.createBranchUniversalObject = function(options) { * | feature | String | The link feature | * | alias | String | The link alias | * | channel | String | The link channel | + * | campaign | String | The link campaign | * | stage | String | The link stage | * | duration | Int | The link duration | * -------------------------------------------------- diff --git a/www/branch.js b/www/branch.js index 79771785..07452af5 100644 --- a/www/branch.js +++ b/www/branch.js @@ -274,6 +274,7 @@ Branch.prototype.createBranchUniversalObject = function (options) { * | feature | String | The link feature | * | alias | String | The link alias | * | channel | String | The link channel | + * | campaign | String | The link campaign | * | stage | String | The link stage | * | duration | Int | The link duration | * -------------------------------------------------- @@ -313,6 +314,7 @@ Branch.prototype.createBranchUniversalObject = function (options) { * | feature | String | The link feature | * | alias | String | The link alias | * | channel | String | The link channel | + * | campaign | String | The link campaign | * | stage | String | The link stage | * | duration | Int | The link duration | * --------------------------------------------------