Skip to content

Commit

Permalink
chore(lint): implement linting in gulpfile
Browse files Browse the repository at this point in the history
  • Loading branch information
amit-bansil committed Aug 8, 2016
1 parent 8ccc563 commit 0cbe741
Show file tree
Hide file tree
Showing 3 changed files with 42 additions and 6 deletions.
2 changes: 0 additions & 2 deletions .jscs → .jscsrc
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
{
"fileExtensions": [".js", ".jsx"],
"esnext": true,

"requireCurlyBraces": [ "if", "else", "for", "while", "do", "try", "catch" ],
"requireSpaceAfterKeywords": [ "if", "else", "for", "while", "do", "switch", "return", "try", "catch" ],
"requireSpaceBeforeBlockStatements": true,
Expand Down
43 changes: 39 additions & 4 deletions gulpfile.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
var gulp = require('gulp');
var fs = require('fs');
var gulp = require('gulp');
var fs = require('fs');
var sourcemaps = require('gulp-sourcemaps');
var babel = require('gulp-babel');
var babel = require('gulp-babel');
var eslint = require('gulp-eslint');
var jscs = require('gulp-jscs');

gulp.task('build-npm', ['setupNpm', 'babel', 'lint']);

Expand Down Expand Up @@ -106,4 +108,37 @@ babelize('hooks');
babelize('www');
babelize('tests');
babelize('testbed', 'testbed/www/js');
gulp.task('babel', babelTasks);
gulp.task('babel', babelTasks);

//------------------------------------------------------------------------------
//linting

gulp.task('lint', ['eslint', 'jscs-lint']);

var srcs = [
'**/*.js',
'!node_modules/**',
'!testbed/platforms/ios/cordova/node_modules/**'
];

gulp.task('lint', () => {
return gulp.src(srcs)
.pipe(eslint())
.pipe(eslint.format())
.pipe(eslint.failAfterError());
});

function jscsTask(fix){
var ret = gulp.src(srcs)
.pipe(jscs({fix: fix}))
.pipe(jscs.reporter())
.pipe(jscs.reporter('fail'));

if(fix){
ret.pipe(gulp.dest('.'));
}
return ret;
}

gulp.task('jscs-fix', jscsTask.bind(null, true));
gulp.task('jscs-lint', jscsTask.bind(null, false));
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,16 @@
"xml2js": "^0.4.16"
},
"devDependencies": {
"babel-eslint": "^6.1.2",
"babel-plugin-transform-runtime": "^6.12.0",
"babel-preset-es2015": "^6.9.0",
"babel-preset-stage-2": "^6.11.0",
"commitizen": "^2.8.2",
"cz-conventional-changelog": "^1.1.6",
"gulp": "^3.9.1",
"gulp-babel": "^6.1.2",
"gulp-eslint": "^3.0.1",
"gulp-jscs": "^4.0.0",
"gulp-sourcemaps": "^1.6.0",
"mkpath": "^1.0.0",
"node-version-compare": "^1.0.1",
Expand Down

0 comments on commit 0cbe741

Please sign in to comment.