fix: added back options to buo methods

BranchMetrics · Apr 26, 2018 · 8b5c50d · 8b5c50d
1 parent b74bfda
commit 8b5c50d
Showing 1 changed file with 14 additions and 10 deletions.
diff --git a/src/branch.js b/src/branch.js
@@ -54,6 +54,10 @@ Branch.prototype.disableTracking = function disableTracking(isEnabled) {
 };
 
 Branch.prototype.initSession = function initSession(deepLinkDataListener) {
+  // handle double init from onResume on iOS
+  if (!runOnce) return new Promise(function promise(resolve, reject) {});
+  runOnce = deviceVendor.indexOf("Apple") < 0;
+
   // private method to filter out +clicked_branch_link = false in deep link callback
   function deepLinkDataParser(deepLinkData) {
     var timestamp = "+click_timestamp";
@@ -86,10 +90,6 @@ Branch.prototype.initSession = function initSession(deepLinkDataListener) {
     previousLinkTimestamp = currentLinkTimestamp;
   }
 
-  // handle double init from onResume on iOS
-  if (!runOnce) return new Promise(function promise(resolve, reject) {});
-  runOnce = deviceVendor.indexOf("Apple") < 0;
-
   if (
     !isDisableGlobalListenersWarnings &&
     !deepLinkDataListener &&
@@ -222,24 +222,28 @@ Branch.prototype.createBranchUniversalObject = function createBranchUniversalObj
           return execute("registerView", [obj.instanceId]);
         };
 
-        obj.generateShortUrl = function generateShortUrl(controlParameters) {
+        obj.generateShortUrl = function generateShortUrl(
+          analytics,
+          properties
+        ) {
           return execute("generateShortUrl", [
             obj.instanceId,
-            options,
-            controlParameters
+            analytics,
+            properties
           ]);
         };
 
         obj.showShareSheet = function showShareSheet(
-          controlParameters,
+          analytics,
+          properties,
           shareText
         ) {
           var message = !shareText ? "This stuff is awesome: " : shareText;
 
           return execute("showShareSheet", [
             obj.instanceId,
-            options,
-            controlParameters,
+            analytics,
+            properties,
             message
           ]);
         };