Merge pull request #148 from BranchMetrics/fix/init-session-while-off…

…line [FIX] Fixed NonBranchLinkHandler when app is offline.
BranchMetrics · May 29, 2016 · c7b0d8e · c7b0d8e
2 parents 6ce246f + f743662
commit c7b0d8e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/src/android/io/branch/BranchSDK.java b/src/android/io/branch/BranchSDK.java
@@ -713,7 +713,7 @@ public void onInitFinished(JSONObject referringParams, BranchError error) {
             } else {
                 String errorMessage = error.getMessage();
 
-                out = String.format("NonBranchLinkHandler(%s)", error.toString());
+                out = String.format("NonBranchLinkHandler(\"%s\")", error.toString());
                 webView.sendJavascript(out);
 
                 if (this._callbackContext != null) {

diff --git a/testbed/www/js/index.js b/testbed/www/js/index.js
@@ -69,13 +69,6 @@ function NonBranchLinkHandler(data)
     }
 }
 
-function NonBranchLinkHandler(data)
-{
-    if (data) {
-        alert('Non-branch link found: ' + JSON.stringify(data));
-    }
-}
-
 function SetDebug(isEnabled)
 {
     console.log('Trigger SetDebug()');

diff --git a/www/branch.js b/www/branch.js
@@ -390,4 +390,11 @@ Branch.prototype.creditHistory = function () {
 
 };
 
+/**
+ * NonBranchLinkHandler callback placeholder.
+ * 
+ * @param {String} response
+ */
+window.NonBranchLinkHandler = (typeof NonBranchLinkHandler === 'undefined') ? function (response) {} : NonBranchLinkHandler;
+
 module.exports = new Branch;