Skip to content

Commit

Permalink
[CHORE] Added contentType field for branch universal link.
Browse files Browse the repository at this point in the history
  • Loading branch information
Renemari Padillo committed Jun 29, 2016
1 parent 9775881 commit da69737
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,7 @@ Branch.createBranchUniversalObject({
title: 'Just another title',
contentDescription: 'Just another description',
contentImageUrl: '/img.jpg',
contentType: 'text',
contentIndexingMode: 'public'
}).then(function (newBranchUniversalObj) {
// Success Callback
Expand Down
3 changes: 3 additions & 0 deletions src/android/io/branch/BranchSDK.java
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,9 @@ private void createBranchUniversalObject(JSONObject options, CallbackContext cal
if (options.has("contentImageUrl")) {
branchObj.setContentImageUrl(options.getString("contentImageUrl"));
}
if (options.has("contentType")) {
branchObj.setContentType(options.getInt("contentType"));

This comment has been minimized.

Copy link
@peterholcomb

peterholcomb Jul 1, 2016

This won't compile. branchObj.setContentType only accepts a string.

This comment has been minimized.

Copy link
@renesansz

renesansz Jul 1, 2016

Contributor

@peterholcomb , thanks for pointing out, will submit update asap. :D

}

// Set content visibility
if (options.has("contentIndexingMode")) {
Expand Down

0 comments on commit da69737

Please sign in to comment.