Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SessionParams only read from defaults when already set #107

Closed
TheMarshal99 opened this issue Apr 15, 2016 · 2 comments
Closed

SessionParams only read from defaults when already set #107

TheMarshal99 opened this issue Apr 15, 2016 · 2 comments

Comments

@TheMarshal99
Copy link

TheMarshal99 commented Apr 15, 2016

Link

@TheMarshal99
Copy link
Author

This of course means that if the _sessionParams object had ever changed, it would always get overwritten with whatever was in the defaults.

@aaustin
Copy link
Contributor

aaustin commented Apr 17, 2016

Resolved in main repo

@aaustin aaustin closed this as completed Apr 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants