Align npm package name with plugin ID in plugin.xml

[jakub-g]

Hello,

FYI, in plugin.xml you have

https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking/blob/master/plugin.xml#L28

<plugin ... id="io.branch.sdk" version="2.1.10">

whereas the package name of the plugin in npm is branch-cordova-sdk

This discrepancy is confusing, no other cordova plugin we're using is doing this.

We found this out because we have some tooling put in place that verifies before build if each plugin from app's package.json (we use ionic) is installed, and up to date, by checking ./plugins/${npm-package-name}/plugin.xml and/or package.json, but in your case, the folder created in plugins dir is
io.branch.sdk, not branch-cordova-sdk as the npm repo name suggests.

[aaustin]

That is suspicious. I'm not sure when this occurred. It'll be hard to change the name on NPM, but it shouldn't be too hard to change the plugin title.

Do you foresee any breaking changes if we were to change the id of the plugin in terms of backwards compatibility?

cc @amit-bansil

[amit-bansil]

My concern is that when you install if the plugin id changes you'll end up
with a new copy and an old copy. Maybe we can test on the testbed and then
see what the plugins directory contains? I'm not at a computer until Monday
but can look into it then.

On Sun, Aug 14, 2016 at 2:57 PM Alex Austin notifications@github.com
wrote:

That is suspicious. I'm not sure when this occurred. It'll be hard to
change the name on NPM, but it shouldn't be too hard to change the plugin
title.

Do you foresee any breaking changes if we were to change the id of the
plugin in terms of backwards compatibility?

cc @amit-bansil https://github.com/amit-bansil

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#199 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAkDPL4Voa_hdBnfAToT208Xc_6pUZuHks5qf2U0gaJpZM4JjA_7
.

[amit-bansil]

I've tested several approaches to solving this problem and it looks like there is no way to change the plugin id without ending up with two copies of the plugin installed on update. As such, although I completely understand your concern @jakub-g, at this stage in the game I think we are stuck with the mistake. I'm closing this issue.