Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch Links Cutoff in iMessage #374

Closed
captaincole opened this issue Sep 28, 2017 · 3 comments
Closed

Branch Links Cutoff in iMessage #374

captaincole opened this issue Sep 28, 2017 · 3 comments

Comments

@captaincole
Copy link

When generating a branch link we dynamically create the link based on a specific item people are trying to find.

    Branch.createBranchUniversalObject(props).then((res) => {
        branchUniversalObj = res;

        let props = {
          $deeplink_path: '/app/challenge/' + this.challenge._id
        };

        let analytics = {
          channel: 'in_app',
          feature: 'invite_challenge',
          campaign: 'in_app'
        };

        let message = '<insert message>';

        branchUniversalObj.showShareSheet(analytics, props, message);
      }).catch(function (err) {
        console.log('Universal Error: ' + JSON.stringify(err));
        // alert('Universal Object Error: ' + JSON.stringify(err))
      });

But when someone tries to share this with iMessage, the link gets cutoff

cutoff-link

link looks like https://38plank.app.link/qifygS7kN (not an actual link)
Not sure what is causing iMessage to recognize the link oddly.

@ethanneff
Copy link
Contributor

Hello,

Thank you for reaching out. This is a known bug with our underlying iOS SDK for deep links which are copy-pasted into iMessage on iOS 11. The current workaround is for users to use sharesheet method to share links to iMessage instead of copy-paste.

This bug has been identified, fixed, and is currently in QA. I will update the Branch Cordova SDK and update you once it is live.

In the meantime, I apologize for this inconvenience.

@ethanneff
Copy link
Contributor

ethanneff commented Oct 2, 2017

Hello again,

I have just updated the Branch Cordova SDK to use the latest underlying Branch iOS SDK. I would recommend updating to the latest version 2.6.14. You can use this guide to update your Cordova Branch SDK. This version should fix the issue you were experiencing.

Thank you for your patience,

@captaincole
Copy link
Author

Thanks @ethanneff . Will be updating today and testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants