-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to build on android (w/ pushbots plugin) #94
Comments
@optikalefx |
ok, ill try to give you any more info I find as I dive into this as well |
The last known working date on this was feb 23rd |
Checking out both coded bases around that date allows it to work. (and of course changing the interface for branch to allow running this back then) |
pushbots plugin does not have to be set back on the 23rd. So the latest pushbots with #81d4aed7f0d0a5f32226cfc0b0fc20b4a0c500da of branch works. |
Thanks for the info @optikalefx , |
So far, the difference with the commits are only the iOS changes.. |
I'm using Pushbots on https://github.com/pushbots/phonegap/tree/master and branch on the commit one mentioned above. Side note - It's possible that iOS changes can affect an android build. wkWebView used to mess that up to the point that I had to have that iOS specific plugin commented one when building for android. |
@optikalefx, |
So starting with bff6c97 all the way up to the latest it throws the same cordova build errors found here pushbots/phonegap#33 I can paste more examples but it's always the same build error.
Slightly different if I build without crosswalk, but similar error.
These are both built with the latest versions of both plugins. |
@optikalefx , At the moment, can you re-build your app by doing the following:
I'll give you an update once I've made any progress on replicating the issue. |
@optikalefx ,
References:
Let me know if this fixes the issue. |
So this does fix it, do you know if there is a way to do this from the plugin perspective? Having to do this on every build is obviously a pain. Also I have a build step so I'd need to add this file manipulation in there at some point if the plugin can't add this. Maybe you have an option to add multiDex from your end? |
Hey @optikalefx , Glad to hear that the fix works for you. At the moment, you can only modify the |
The only way I know to do this otherwise is to create a pre-build hook sh file that does string regex. Not the most ideal for sure. Looking forward to seeing what you find |
I see, I'll try to look at it if its doable. I'll let you know if I'm able to automate it. Cheers, |
I found an automatic way in my grunt-phonegap setup. Using shell js inside of a before-build file. in _phonegap.xml
inside of the before build file
|
@optikalefx , Closing the issue now. Cheers, |
yea I don't thinks should be included for you, but at least this ticket is here for others. |
Ref pushbots/phonegap#33
The text was updated successfully, but these errors were encountered: