Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default text of showShareSheet #97

Closed
rklus16 opened this issue Apr 12, 2016 · 7 comments
Closed

Default text of showShareSheet #97

rklus16 opened this issue Apr 12, 2016 · 7 comments

Comments

@rklus16
Copy link

rklus16 commented Apr 12, 2016

Is it possible to change the default text "Share link" in the showShareSheet?

img_0017

@rt2zz
Copy link

rt2zz commented Apr 12, 2016

upon cursory inspection it looks like the fourth argument to showShareSheet will be set as the share text https://github.com/BranchMetrics/Cordova-Ionic-PhoneGap-Deferred-Deep-Linking-SDK/blob/master/src/ios/BranchSDK.m#L474

@rklus16
Copy link
Author

rklus16 commented Apr 12, 2016

looks like showShareSheet only take 2 args showShareSheet(options, controlParameters) so I'm not sure what the third and fourth arguments are. I tried this

showShareSheet(options, controlParams, 'my example text');

@rt2zz
Copy link

rt2zz commented Apr 12, 2016

Ah true, it looks like www/branch.js is lacking support atm

@TheMarshal99
Copy link

@renesansz
Copy link
Contributor

Hey everyone,
Just have created a PR #99 to support customizing the share text.

@jestoniyap
Copy link
Contributor

@rklus16 Please check if the latest version fixes the issue. Then we can close this thread. Thanks.

@rklus16
Copy link
Author

rklus16 commented Apr 18, 2016

Works! Thanks for doing that! 😃

@rklus16 rklus16 closed this as completed Apr 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants