Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sp_BlitzLock needs a facelift #3166

Closed
erikdarlingdata opened this issue Nov 9, 2022 · 1 comment · Fixed by #3179
Closed

sp_BlitzLock needs a facelift #3166

erikdarlingdata opened this issue Nov 9, 2022 · 1 comment · Fixed by #3179

Comments

@erikdarlingdata
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Since we're coming up on the 6th anniversary of this thing getting written on the plane ride to PASS, there are a number of issues, shortcomings, and enhancements I'd like to knock out for this at once.

  • Be able to read from an event file or the ring buffer
  • Improve performance generally: some of the XML stuff has obvious issues
  • Fix several data duplication bugs
  • Clean XML to address occasional character parsing errors
  • Resolve [Database Id = 5 Object Id = 98489874] entries

You get the idea. It has gone largely untouched in important ways for a long time.

Describe the solution you'd like
I would like to work on this to implement everything in a single issue, with as few passes as possible. I just need to get in there and plug through everything.

Describe alternatives you've considered
Continue to wonder why I don't just fix this stuff.

Are you ready to build the code for the feature?
My soul is prepared! How's yours?

@BrentOzar
Copy link
Member

Thanks for the pull request! I'm not even gonna pretend I reviewed the code in this, hahaha - you da man. Merging into the dev branch, will be in the December to Remember release with credit to you in the release notes.

@BrentOzar BrentOzar added this to the 2022-12 Release milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment