Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatabaseSchemaHelper defines mash.name as not null #149

Closed
mikfire opened this issue Jan 26, 2016 · 4 comments
Closed

DatabaseSchemaHelper defines mash.name as not null #149

mikfire opened this issue Jan 26, 2016 · 4 comments

Comments

@mikfire
Copy link
Contributor

mikfire commented Jan 26, 2016

As with anything mentioning DatabaseSchemaHelper, this can be ignored for the 2.3.0 release.

According to the definitions in DatabaseSchemaHelper::create(), mash.name is not null. My personal database has approximately 95 mash entries with a null name. As mashes are not named by default, I am assuming DatabaseSchemaHelper::create() is wrong in this instance.

Assign this to me, I will fix when I'm done with other things.

@mikfire
Copy link
Contributor Author

mikfire commented Jan 26, 2016

To quote a serbian friend, huuuu. I have three very odd mashstep entries with no name either. They look completely bogus, and I've cleaned them out.

Could the other devs check to see if they have similar bogus entries? Open up the sqlite database and run this query:
select * from mashstep where name='';

@rocketman768
Copy link
Member

null is not the same as empty''. The query for a null name would be

select * from mash where name is null;

@rocketman768
Copy link
Member

Working as designed?

@rocketman768
Copy link
Member

Closing as WAD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants