Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need changedFolder signal? #707

Open
matty0ung opened this issue Jan 1, 2023 · 1 comment
Open

Do we need changedFolder signal? #707

matty0ung opened this issue Jan 1, 2023 · 1 comment

Comments

@matty0ung
Copy link
Contributor

Following on from #703, I see we declare changedFolder signal on NamedEntity but I can't find anywhere in the code where we actually emit this signal.

Is it something old that we can remove? Or is something currently broken because this signal isn't getting sent?

@mikfire
Copy link
Contributor

mikfire commented Jan 1, 2023

I am honestly uncertain. Everything with folders seems to work, although I cannot drop a folder onto another folder. I would need to build the old code to remember if that feature worked or not.

Half a neuron is suggesting I wrote that expecting to need it, and then realized it wasn't needed. Since folders only ever existed in trees, I could simply call the folderChanged() method directly and not muck about with signals.

Let me pull the old code into a vm tomorrow and make sure of a few things. I will comment the connect in BtTreeModel out and see what breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants