Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hop editor crashes App #717

Closed
Melonbob opened this issue Feb 4, 2023 · 4 comments
Closed

Hop editor crashes App #717

Melonbob opened this issue Feb 4, 2023 · 4 comments

Comments

@Melonbob
Copy link

Melonbob commented Feb 4, 2023

The installed default database from developer branch builds doesn't coincide with the DefaultData.xml at least with hop records. The db is leaf and the xml is pellets. How do I rebuild it from the xml?

Also when I went to edit with the Hop editor window, the pull-down menus were duplicated. The top set crashes the App while the bottom set does not.

image1

image2

image3

@matty0ung
Copy link
Contributor

Ooh, I thought I'd fixed this, sorry. It's a bug caused by when I accidentally brought to much of the "in development" BeerJSON work into the dev branch. I'm travelling at the moment but will try to get a fix in the coming week.

@matty0ung
Copy link
Contributor

So I've done a fix for the UI bit. The data import bit probably needs a bit more looking at. Do you see any errors in the logs when you start up with a clean database? What is supposed to happen is that the code should read the contents of DefaultData.xml into the DB using the regular XML import process. If that fails for some reason then, usually, there should be some error message in the logs.

(The reason all this is being changed for BeerJSON is that it recognises additional forms of hops (Extract, Wet Leaf and Powder) that don't exist in BeerXML and therefore we didn't previously support.)

@Melonbob
Copy link
Author

Melonbob commented Feb 6, 2023

I put the log here from startup here. Looks like a clean, normal startup.
#714 (comment)

@Melonbob
Copy link
Author

Melonbob commented Feb 6, 2023

My MSYS2 MINGW32 package build with the current upstream has resolved this. See also:
#711 (comment)

@Melonbob Melonbob closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants