Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Session date not shown for sprint shootouts #142

Closed
Rafee-M opened this issue Apr 8, 2024 · 4 comments
Closed

[BUG] Session date not shown for sprint shootouts #142

Rafee-M opened this issue Apr 8, 2024 · 4 comments
Milestone

Comments

@Rafee-M
Copy link
Contributor

Rafee-M commented Apr 8, 2024

Dates for everything else works fine, just the sprint shootout seems to not show the date. It would be nice if it could.

Record_2024-04-08-09-13-15_1.mp4
@BrightDV
Copy link
Owner

With the API currently used (Ergast), there is not such information, so I can't add it.
image

However, I am planning to also support F1's API, so it may be available when the support is added.
Chinese GP:

As you can see, there are much more details
{
    "timetables": [
        {
            "state": "upcoming",
            "session": "r",
            "gmtOffset": "+08:00",
            "description": "Race",
            "endTime": "2024-04-21T17:00:00",
            "startTime": "2024-04-21T15:00:00"
        },
        {
            "state": "upcoming",
            "session": "s",
            "gmtOffset": "+08:00",
            "description": "Sprint",
            "endTime": "2024-04-20T12:00:00",
            "startTime": "2024-04-20T11:00:00"
        },
        {
            "state": "upcoming",
            "session": "ss",
            "gmtOffset": "+08:00",
            "description": "Sprint Qualifying",
            "endTime": "2024-04-19T16:14:00",
            "startTime": "2024-04-19T15:30:00"
        },
        {
            "state": "upcoming",
            "session": "p1",
            "gmtOffset": "+08:00",
            "description": "Practice 1",
            "endTime": "2024-04-19T12:30:00",
            "startTime": "2024-04-19T11:30:00"
        },
        {
            "state": "upcoming",
            "session": "q",
            "gmtOffset": "+08:00",
            "description": "Qualifying",
            "endTime": "2024-04-20T16:00:00",
            "startTime": "2024-04-20T15:00:00"
        }
    ]
}

@BrightDV
Copy link
Owner

My bad, I just saw that the SecondPractice element has the Sprint Qualifying data...

@BrightDV BrightDV added this to the 0.7.3 milestone Apr 18, 2024
@BrightDV
Copy link
Owner

I also updated the app to support the new name of the sprint qualifs, thanks for the issue!

@Rafee-M
Copy link
Contributor Author

Rafee-M commented Apr 19, 2024

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants