Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DAYL-94 Update Collapsible-Panel A11y Docn #5208

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

ChrisLabattD2L
Copy link
Contributor

JIRA Story

Similarly to many of the other PRs, this is another improvement to the a11y docn of the collapsible-panel component. The main changes involved adding the ACCESSIBILITY tag to a11y-based properties and also cleaned up a bit of the readme (removing some unnecessary imports in some of the demos) along with adding to the a11y section, which already had quite a bit of content.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-5208/

Note

The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

Copy link
Contributor

@geurts geurts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks Chris! Sorry I lost this in my inbox til now, Nathan had to remind me.

components/collapsible-panel/README.md Outdated Show resolved Hide resolved
@ChrisLabattD2L ChrisLabattD2L marked this pull request as ready for review December 16, 2024 19:05
@ChrisLabattD2L ChrisLabattD2L requested a review from a team as a code owner December 16, 2024 19:05
@dlockhart dlockhart merged commit 1f7b602 into main Dec 20, 2024
6 checks passed
@dlockhart dlockhart deleted the clabatt/DAYL-94-Collapsible-Panel-A11y-Docn branch December 20, 2024 20:04
Copy link

🎉 This PR is included in version 3.77.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants