feat: call listeners after other important attributes change #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
margaree
commented
Nov 26, 2021
| @@ -121,6 +121,7 @@ class DocumentLocaleSettings { | |||
| } | |||
| } | |||
| this._overrides = val; | |||
| this._listeners.forEach((cb) => cb()); | |||
There was a problem hiding this comment.
So I wasn't sure of a completely ideal way to do all this. Since overrides, language, and fallbackLanguage can technically get changed through .fallbackLanguage etc., they should call the listeners, so I didn't want to duplicate that in _handleObserverChange, but it feels a bit weird to have two different ways that the calls are happening.
| @@ -124,61 +124,98 @@ describe('common', () => { | |||
|
|
|||
| describe('document mutations', () => { | |||
| it('should update language if "lang" gets set', (done) => { | |||
| documentLocaleSettings.addChangeListener(() => { | |||
| const cb = () => { | |||
There was a problem hiding this comment.
Since afterEach was resetting the attributes, these listeners were getting called again, causing an error about done being called multiple times.
dlockhart
approved these changes
Nov 26, 2021
|
🎉 This PR is included in version 3.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.