Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DE46356 - Update BrightspaceUI to match core French date changes #98

Merged
merged 2 commits into from
Dec 15, 2021
Merged

DE46356 - Update BrightspaceUI to match core French date changes #98

merged 2 commits into from
Dec 15, 2021

Conversation

joshhoey
Copy link
Contributor

  • Removing "le" from long date format of fr-ca and fr-fr ("le" remains in fr-on).
  • Making other elements consistent with formats in LOCALE_CULTURE.
  • Updating tests to match new values.

dlockhart
dlockhart approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@dlockhart dlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dlockhart dlockhart merged commit 0602479 into main Dec 15, 2021
@dlockhart dlockhart deleted the DE46356-FrenchDateChangesToUI branch December 15, 2021 16:58
@ghost
Copy link

ghost commented Dec 15, 2021

🎉 This PR is included in version 3.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Dec 15, 2021
@joshhoey joshhoey mentioned this pull request Dec 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlockhart dlockhart dlockhart approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshhoey @dlockhart