Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid "heartbeat interval" option when using engine.io@^4.0.0 #1925

Closed
chris-allen opened this issue Feb 10, 2022 · 1 comment · Fixed by #1936
Closed

Invalid "heartbeat interval" option when using engine.io@^4.0.0 #1925

chris-allen opened this issue Feb 10, 2022 · 1 comment · Fixed by #1936

Comments

@chris-allen
Copy link

In attempting to comply with CVE-2020-36048, forcing engine.io to resolve to ^4.0.0 results in the following error:

Option heartbeat interval is not valid. Please refer to the README.

I don't see the removal of the heartbeat interval option called out in the enginge.io CHANGELOG, but there is this blog post about the engine.io 4 release (now on 6.1.2).

Browsersync Node Npm
2.27.7 4.18.3 6.14.15

Usage

gulp.task('watch', function() {
  browserSync.init({
    socket: {
      domain: 'myapp-sync.lndo.site'
    },
    logLevel: 'silent',
    notify: false,
    cors: true,
    server: {
      baseDir: '.',
    },
    open: false,
  });
  ...
});
@lachieh
Copy link
Contributor

lachieh commented Feb 24, 2022

Duplicate issue. See #1850 for original.

This was referenced Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants