Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenBrush x Stable Rust #58

Closed
5 tasks done
coreggon11 opened this issue May 10, 2023 · 4 comments
Closed
5 tasks done

OpenBrush x Stable Rust #58

coreggon11 opened this issue May 10, 2023 · 4 comments
Assignees

Comments

@coreggon11
Copy link
Contributor

coreggon11 commented May 10, 2023

rustc 1.71 introduced some changes to min specialization

rust-lang/rust#111252

We will remove min_specialization altogether, so we will no longer depend on nightly features, as they may introduce breaking changes to a stable product. However, this would remove some of OpenBrush's unique features, which must be implemented differently.

TODO:

  • Remove min specialization
  • Update OpenBrush to use new trait system
  • new macro to implement all needed traits
  • Examples building
  • Tests working

Implemented in #78

@coreggon11 coreggon11 self-assigned this May 10, 2023
@PierreOssun
Copy link
Contributor

Will this makes OB compile in stable ?

@coreggon11
Copy link
Contributor Author

Will this makes OB compile in stable ?

yes)

@deuszx
Copy link

deuszx commented May 25, 2023

How do you plan on supporting default fns in default impls?

@Artemka374
Copy link
Contributor

Hi @deuszx, we are planning to use a bit another approach for it, with use of macros

@coreggon11 coreggon11 changed the title Updates to min specilazation Stable version of rust in OpenBrush May 31, 2023
@coreggon11 coreggon11 changed the title Stable version of rust in OpenBrush OpenBrush x Stable Rust Jun 2, 2023
@coreggon11 coreggon11 mentioned this issue Jun 2, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants