Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0 metrics #15118

Merged
merged 16 commits into from
Dec 9, 2024
Merged

3.0 metrics #15118

merged 16 commits into from
Dec 9, 2024

Conversation

shogunpurple
Copy link
Member

@shogunpurple shogunpurple commented Dec 4, 2024

Description

This PR adds telemetry for the 3.0 launch features for features that didn't have them

  • - row actions
  • - views, calculation views and view joins
  • - AI column
  • - grouped filtering
  • - Default values

Remove view v1 events - these weren't being tracked (for updates), weren't seeing much use in general, and are now legacy.

Addresses

Launchcontrol

Adds telemetry for 3.0 features

Copy link

qa-wolf bot commented Dec 4, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@shogunpurple shogunpurple marked this pull request as ready for review December 6, 2024 16:32
@shogunpurple shogunpurple requested a review from a team as a code owner December 6, 2024 16:32
@shogunpurple shogunpurple requested review from adrinr and removed request for a team December 6, 2024 16:32
@shogunpurple shogunpurple changed the title WIP basic 3.0 metrics 3.0 metrics Dec 6, 2024
@shogunpurple shogunpurple force-pushed the 3.0-metrics branch 2 times, most recently from 05f1d31 to 20305d7 Compare December 9, 2024 00:25
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the view filter event changes!

@shogunpurple shogunpurple merged commit 3d8b415 into master Dec 9, 2024
19 checks passed
@shogunpurple shogunpurple deleted the 3.0-metrics branch December 9, 2024 15:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants