-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.0 metrics #15118
Merged
Merged
3.0 metrics #15118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
shogunpurple
force-pushed
the
3.0-metrics
branch
from
December 5, 2024 17:33
955bf75
to
3332f2f
Compare
shogunpurple
force-pushed
the
3.0-metrics
branch
2 times, most recently
from
December 9, 2024 00:25
05f1d31
to
20305d7
Compare
shogunpurple
force-pushed
the
3.0-metrics
branch
from
December 9, 2024 00:26
20305d7
to
ec84cf1
Compare
samwho
reviewed
Dec 9, 2024
mike12345567
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for the view filter event changes!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds telemetry for the 3.0 launch features for features that didn't have them
Remove view v1 events - these weren't being tracked (for updates), weren't seeing much use in general, and are now legacy.
Addresses
Launchcontrol
Adds telemetry for 3.0 features