Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema exporting. #15123

Merged

Conversation

samwho
Copy link
Collaborator

@samwho samwho commented Dec 5, 2024

Description

Prior to this PR, schema exporting for our databases that support it (Postgres, MSSQL, MySQL, and MariaDB) resulted in broken schemas most of the time.

This PR introduces a test that does the following:

  1. Create a table through Budibase.
  2. Export datasource schema.
  3. Delete the created table.
  4. Run the exported schema.
  5. Import the table back into Budibase.
  6. Assert the old table matches the new one.

This was failing variously for all of our databases prior to this PR, but is passing after.

Launchcontrol

  • A variety of fixes to schema exporting for Postgres, MSSQL, MySQL, and MariaDB.

@samwho samwho requested a review from a team as a code owner December 5, 2024 10:49
@samwho samwho requested review from mike12345567 and removed request for a team December 5, 2024 10:49
Copy link

linear bot commented Dec 5, 2024

Copy link

qa-wolf bot commented Dec 5, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/m labels Dec 5, 2024
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work on this - great idea with the test as well, good way to prove it!

@samwho samwho merged commit b05effa into master Dec 5, 2024
19 checks passed
@samwho samwho deleted the budi-8882-ms-sql-export-schema-feature-creates-and-downloads branch December 5, 2024 11:20
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants