Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop coercing all values to strings when using CoreCheckboxGroup #15136

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Stop coercing all values to strings when using CoreCheckboxGroup #15136

merged 4 commits into from
Dec 10, 2024

Conversation

aptkingston
Copy link
Member

@qa-wolf QA Wolf
Copy link

qa-wolf bot commented Dec 6, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@aptkingston aptkingston marked this pull request as ready for review December 6, 2024 14:31
deanhannigan
deanhannigan approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@deanhannigan deanhannigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aptkingston aptkingston enabled auto-merge December 9, 2024 10:39
@aptkingston aptkingston merged commit a3c1bbc into master Dec 10, 2024
19 checks passed
@aptkingston aptkingston deleted the fix-multi-checkbox-value-coercion branch December 10, 2024 14:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deanhannigan deanhannigan deanhannigan approved these changes

Assignees
No one assigned
Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aptkingston @deanhannigan