Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle cases where datasourceName is undefined when sorting datasources #15140

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

andz-bb
Copy link
Contributor

@andz-bb andz-bb commented Dec 9, 2024

Description

Users table doesn't have a datasource name so currently crashes the builder when you create a table.

Screenshots

image

Launchcontrol

Fix bug with sorting datasource names

@andz-bb andz-bb requested a review from deanhannigan December 9, 2024 10:32
Copy link

qa-wolf bot commented Dec 9, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link
Contributor

@deanhannigan deanhannigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andz-bb andz-bb enabled auto-merge December 9, 2024 10:34
@andz-bb andz-bb merged commit d725d49 into master Dec 9, 2024
19 checks passed
@andz-bb andz-bb deleted the datasource-sorting-fix branch December 9, 2024 10:36
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants