Custom role in groups issue #15166
Merged
Custom role in groups issue #15166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
adrinr
force-pushed
the
BUDI-7710/custom-role-issue
branch
from
0ea29f6 to
81bf878
Compare
aptkingston
approved these changes
Dec 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing an issue with custom roles. If we have a single custom role, it has role order 0, but the check it not contemplating this properly. This PR just adds a test catching the error and fixes the issue.
Also, fixing the client dev build to not be minimised, as I had some struggles while trying to find the origin of the issue
Related:
Launchcontrol
Fixing an issue with custom roles in groups