credit where it's due...

[PureArtistry]

It looks like my version of the script is about to become the new main and as it's basically a complete re-write of the core logic that necessitated shuffling a lot of the script around...

it's basically only my name in the blame!

This really doesn't seem fair to the many contributors, I haven't spent a second scraping the html for snippets for example.

I'm trying to add credit where I can in comments in the script but I'm not really sure who has contributed what.

So if you want your name in there please let me know where I should add it, thanks!

[BeyondMagic]

I'm trying to add credit where I can in comments in the script but I'm not really sure who has contributed what.

@Bugswriter wrote the scraping of corrections/did_you_mean, also Knowledge Graph, Basic answers, Featured Snippets.; and one class of Rich Answers was made by him.

@karthink added Units and Currency Conversion #44.

[sudocanttype]

Is it ready to be deployed into main? I've run into a couple bugs in testing. How about we commit it to the purert branch, and then we can have a bunch of people test it, not just me. Since it is a gigantic rework of the code, we should be wary of unforeseen bugs.

[PureArtistry]

I didn't necessarily mean it was ready right now just that it seems that was the eventual direction things were heading, sorry if I'm overstepping.

What bugs have you run in to? I can take a look at them now

[sudocanttype]

Ah, I was just saying that we should take things slightly slower. Case in point the develop branch, where we went a little too fast and it blew up, and now no one wants to work in it.
Ok first problem, it goes directly to quotes. I'm pretty sure this is unintended

[sudocanttype]

Lets merge #144, and then I can help hammer out bugs that pop up.

[BeyondMagic]

Is the newline after executing the command intentional?

[PureArtistry]

yeah, it's my personal taste, sorry
it's the printf on line 4, I left it at the top because I figured that would be removed

It's going to quotes because that processes slightly faster than kno_right
the priority variable is kind of a lie because although they are started in that order it basically starts them all simultaneously.

I''ve just tried moving kno_right to the top and it sometimes prints that but often quotes still comes through faster.
I'm going to start working on a smart search feature to help fix this.

[BeyondMagic]

That newline makes me uncomfortable lol

[PureArtistry]

I'll get rid of it in the next commit and just add the newline to my prompt instead

[Bugswriter]

Sorry guys I am busy with my exams .. that's what taking so long for me to merge @PureArtistry version with main.
But I think the way I get PR and issues .. we need to do this soon. I looked at @PureArtistry code it's a massive upgrade.
I want to just merge @PureArtistry version with main just waiting a confirmation from you guys .. that it's ready and I can do this.

[BeyondMagic]

It's not ready yet.

[Bugswriter]

Ok .. the issue is everytime we get a new PR for new feature on main @PureArtistry version lack behind.
So I just want to merge ASAP so we can get new update in his version and forget our old code.

[ghost]

I don't see the need to clutter code with unneeded comments; there are plenty enough as it is, from what I've seen in develop. Credit can be given in a man(1) page, on GitHub, or some other form of documentation (IE: Wiki). That's just my preference, though.