Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(qwik-city): bump vite-imagetools ^5 -> ^6 #5525

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Dec 4, 2023

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Updates the vite-imagetools in the qwik-city package. This contains a newer verison of Sharp underneath that resolves an issue of using Qwik with Deno:

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

The new vite-imagetools version uses a newer Sharp version which will allow Qwik City to work with
Deno

denoland/deno#20612
Copy link

netlify bot commented Dec 4, 2023

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 72894ab

@gioboa
Copy link
Member

gioboa commented Dec 5, 2023

Thanks @birkskyum, v5 to v6 is a big bump.
can you test this change with different environments pls (node)?

@gioboa gioboa added COMP: qwik-city WAITING FOR: user Further information is requested from the issue / pr opener labels Dec 5, 2023
@birkskyum
Copy link
Contributor Author

birkskyum commented Dec 5, 2023

It took me a while to figure out, but I managed to run the full test suite with node 18.19 on my arm64 MacBook, and it checked out. Is there a specific app i can link-install it in to validate further?

@gioboa
Copy link
Member

gioboa commented Dec 5, 2023

if you can try this specific feature will be awesome. thanks

@mhevery
Copy link
Contributor

mhevery commented Dec 6, 2023

I am going to cut 1.3.0 soon so I am going to include this in minor change. Please let us know if your testing uncovers anything.

@mhevery mhevery merged commit c37a2d4 into QwikDev:main Dec 6, 2023
23 checks passed
@birkskyum
Copy link
Contributor Author

birkskyum commented Dec 6, 2023

I installed the Demo app and set:

  "resolutions": {
    "vite-imagetools": "6.2.7"
  }

and it appear to load the lightning in the background just fine

Screenshot 2023-12-06 at 09 04 08

@gioboa
Copy link
Member

gioboa commented Dec 6, 2023

Thank you @birkskyum for this check 👍

kodiakhq bot referenced this pull request in ascorbic/unpic-img Dec 10, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@builder.io/qwik](https://qwik.builder.io/) ([source](https://github.com/BuilderIO/qwik/tree/HEAD/packages/qwik)) | [`1.2.19` -> `1.3.0`](https://renovatebot.com/diffs/npm/@builder.io%2fqwik/1.2.19/1.3.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@builder.io%2fqwik/1.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@builder.io%2fqwik/1.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@builder.io%2fqwik/1.2.19/1.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@builder.io%2fqwik/1.2.19/1.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>BuilderIO/qwik (@&#8203;builder.io/qwik)</summary>

### [`v1.3.0`](https://github.com/BuilderIO/qwik/releases/tag/v1.3.0)

[Compare Source](https://github.com/BuilderIO/qwik/compare/v1.2.19...v1.3.0)

#### Breaking Changes

-   When passing a `Signal` into `track()` directly (instead of passing a function), it returns the signal value instead of the signal itself. This behavior was already present when running inside a `useResource$` callback, and now it is consistent across all Tasks.

#### What's Changed

-   chore: Vite 5 by [@&#8203;wmertens](https://github.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5451](https://github.com/BuilderIO/qwik/pull/5451)
-   feat: add qwik/no-use-visible-task eslint rule by [@&#8203;gioboa](https://github.com/gioboa) in [https://github.com/BuilderIO/qwik/pull/5455](https://github.com/BuilderIO/qwik/pull/5455)
-   chore(insights): remove unnecessary log by [@&#8203;gioboa](https://github.com/gioboa) in [https://github.com/BuilderIO/qwik/pull/5461](https://github.com/BuilderIO/qwik/pull/5461)
-   fix: add example context to docs by [@&#8203;dotarjun](https://github.com/dotarjun) in [https://github.com/BuilderIO/qwik/pull/5467](https://github.com/BuilderIO/qwik/pull/5467)
-   feat(qwik-city): allow customizing SVGO options of image plugin by [@&#8203;hbendev](https://github.com/hbendev) in [https://github.com/BuilderIO/qwik/pull/5407](https://github.com/BuilderIO/qwik/pull/5407)
-   docs: fix typo by [@&#8203;ulic75](https://github.com/ulic75) in [https://github.com/BuilderIO/qwik/pull/5472](https://github.com/BuilderIO/qwik/pull/5472)
-   docs: fix typo by [@&#8203;Adbib](https://github.com/Adbib) in [https://github.com/BuilderIO/qwik/pull/5481](https://github.com/BuilderIO/qwik/pull/5481)
-   fix(core): Support JSX in signals by [@&#8203;mhevery](https://github.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5442](https://github.com/BuilderIO/qwik/pull/5442)
-   docs(FAQ): - lazy-loading on user interaction & speculative module fetching by [@&#8203;maiieul](https://github.com/maiieul) in [https://github.com/BuilderIO/qwik/pull/5488](https://github.com/BuilderIO/qwik/pull/5488)
-   docs(faq): add link to typescript by [@&#8203;maiieul](https://github.com/maiieul) in [https://github.com/BuilderIO/qwik/pull/5487](https://github.com/BuilderIO/qwik/pull/5487)
-   fix: disable Vite modulepreload by [@&#8203;gioboa](https://github.com/gioboa) in [https://github.com/BuilderIO/qwik/pull/5493](https://github.com/BuilderIO/qwik/pull/5493)
-   docs(faq): fix typos and improve the wording of some sentences by [@&#8203;maiieul](https://github.com/maiieul) in [https://github.com/BuilderIO/qwik/pull/5490](https://github.com/BuilderIO/qwik/pull/5490)
-   docs: make the distinction between module-prefetching and <Link prefetch> by [@&#8203;maiieul](https://github.com/maiieul) in [https://github.com/BuilderIO/qwik/pull/5485](https://github.com/BuilderIO/qwik/pull/5485)
-   docs(showcase): add `index.app` and `wiza.co` by [@&#8203;necatikcl](https://github.com/necatikcl) in [https://github.com/BuilderIO/qwik/pull/5484](https://github.com/BuilderIO/qwik/pull/5484)
-   fix(docs): mdx interpreting title as component by [@&#8203;maiieul](https://github.com/maiieul) in [https://github.com/BuilderIO/qwik/pull/5499](https://github.com/BuilderIO/qwik/pull/5499)
-   docs(/faq#vdom): cleanup the vdom section by [@&#8203;maiieul](https://github.com/maiieul) in [https://github.com/BuilderIO/qwik/pull/5500](https://github.com/BuilderIO/qwik/pull/5500)
-   fix: revert "fix: remove cf pages stream polyfill" by [@&#8203;gioboa](https://github.com/gioboa) in [https://github.com/BuilderIO/qwik/pull/5502](https://github.com/BuilderIO/qwik/pull/5502)
-   fix(qwik-city): prefix ids of SVGs based on their path when loaded as qwik nodes by [@&#8203;hbendev](https://github.com/hbendev) in [https://github.com/BuilderIO/qwik/pull/5497](https://github.com/BuilderIO/qwik/pull/5497)
-   fix: cf pages polyfill only if needed by [@&#8203;mpeg](https://github.com/mpeg) in [https://github.com/BuilderIO/qwik/pull/5507](https://github.com/BuilderIO/qwik/pull/5507)
-   refactor(core): extract Group type by [@&#8203;wtlin1228](https://github.com/wtlin1228) in [https://github.com/BuilderIO/qwik/pull/4798](https://github.com/BuilderIO/qwik/pull/4798)
-   docs: add QwikCityMockProvider explanation by [@&#8203;mulztob](https://github.com/mulztob) in [https://github.com/BuilderIO/qwik/pull/5505](https://github.com/BuilderIO/qwik/pull/5505)
-   docs(glob-import): add documentation for import.meta.glob by [@&#8203;maiieul](https://github.com/maiieul) in [https://github.com/BuilderIO/qwik/pull/5504](https://github.com/BuilderIO/qwik/pull/5504)
-   fix: CF pages polyfill also when shimmed by [@&#8203;mpeg](https://github.com/mpeg) in [https://github.com/BuilderIO/qwik/pull/5512](https://github.com/BuilderIO/qwik/pull/5512)
-   fix(qwik): handle cypress dev server path by [@&#8203;dmitry-stepanenko](https://github.com/dmitry-stepanenko) in [https://github.com/BuilderIO/qwik/pull/5509](https://github.com/BuilderIO/qwik/pull/5509)
-   chore(cf): Fix CloudFlare build failure by [@&#8203;mhevery](https://github.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5524](https://github.com/BuilderIO/qwik/pull/5524)
-   docs: removed defunct sites by [@&#8203;mhevery](https://github.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5528](https://github.com/BuilderIO/qwik/pull/5528)
-   chore(netlify): fix netlify failure by [@&#8203;mhevery](https://github.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5527](https://github.com/BuilderIO/qwik/pull/5527)
-   docs(showcase): add juneikerc.com - blog \[prismic cms] and personal website  by [@&#8203;juneikerc](https://github.com/juneikerc) in [https://github.com/BuilderIO/qwik/pull/5523](https://github.com/BuilderIO/qwik/pull/5523)
-   fix(localization-starter): update docs and add script by [@&#8203;tzdesign](https://github.com/tzdesign) in [https://github.com/BuilderIO/qwik/pull/5494](https://github.com/BuilderIO/qwik/pull/5494)
-   chore(qwik-city): bump vite-imagetools ^5 -> ^6 by [@&#8203;birkskyum](https://github.com/birkskyum) in [https://github.com/BuilderIO/qwik/pull/5525](https://github.com/BuilderIO/qwik/pull/5525)
-   feat(insights): polish UI by [@&#8203;zanettin](https://github.com/zanettin) in [https://github.com/BuilderIO/qwik/pull/5503](https://github.com/BuilderIO/qwik/pull/5503)
-   chore: update .nvmrc by [@&#8203;gioboa](https://github.com/gioboa) in [https://github.com/BuilderIO/qwik/pull/5530](https://github.com/BuilderIO/qwik/pull/5530)
-   feat(insight): Add user auth to only see your app data. by [@&#8203;mhevery](https://github.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5517](https://github.com/BuilderIO/qwik/pull/5517)
-   chore(ci): set up CI for insights and docs by [@&#8203;mhevery](https://github.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5533](https://github.com/BuilderIO/qwik/pull/5533)
-   refactor(types): more precision by [@&#8203;wmertens](https://github.com/wmertens) in [https://github.com/BuilderIO/qwik/pull/5531](https://github.com/BuilderIO/qwik/pull/5531)
-   chore: 1.3.0 by [@&#8203;mhevery](https://github.com/mhevery) in [https://github.com/BuilderIO/qwik/pull/5535](https://github.com/BuilderIO/qwik/pull/5535)

#### New Contributors

-   [@&#8203;dotarjun](https://github.com/dotarjun) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5467](https://github.com/BuilderIO/qwik/pull/5467)
-   [@&#8203;Adbib](https://github.com/Adbib) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5481](https://github.com/BuilderIO/qwik/pull/5481)
-   [@&#8203;mulztob](https://github.com/mulztob) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5505](https://github.com/BuilderIO/qwik/pull/5505)
-   [@&#8203;juneikerc](https://github.com/juneikerc) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5523](https://github.com/BuilderIO/qwik/pull/5523)
-   [@&#8203;birkskyum](https://github.com/birkskyum) made their first contribution in [https://github.com/BuilderIO/qwik/pull/5525](https://github.com/BuilderIO/qwik/pull/5525)

**Full Changelog**: QwikDev/qwik@v1.2.19...v1.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP: qwik-city WAITING FOR: user Further information is requested from the issue / pr opener
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants