From 489da6856a92b028dc26f927aaf1f0f039bfc18e Mon Sep 17 00:00:00 2001 From: kflemin Date: Fri, 10 Sep 2021 12:55:46 -0600 Subject: [PATCH 1/2] map common floor-area type --- CHANGELOG.md | 1 + lib/buildingsync/model_articulation/spatial_element.rb | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f0da59df..a71707fb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ - BuildingSync to OpenStudio Translation for MLOD 200 - Add action for building the documentation - Fix purge measures method to only remove measures with SKIP argument set to True +- Map "Common" BuildingSync floor area type ## Version 0.2.0 diff --git a/lib/buildingsync/model_articulation/spatial_element.rb b/lib/buildingsync/model_articulation/spatial_element.rb index 490c1db5..d699abf7 100644 --- a/lib/buildingsync/model_articulation/spatial_element.rb +++ b/lib/buildingsync/model_articulation/spatial_element.rb @@ -89,7 +89,7 @@ def read_floor_areas(parent_total_floor_area) @conditioned_floor_area_heated_cooled = OpenStudio.convert(validate_positive_number_excluding_zero('@heated_and_cooled_floor_area', floor_area), 'ft^2', 'm^2').get elsif floor_area_type == 'Footprint' @footprint_floor_area = OpenStudio.convert(validate_positive_number_excluding_zero('@footprint_floor_area', floor_area), 'ft^2', 'm^2').get - elsif floor_area_type == 'Conditioned' + elsif floor_area_type == 'Conditioned' || floor_area_type == 'Common' @conditioned_floor_area_heated_cooled = OpenStudio.convert(validate_positive_number_excluding_zero('@conditioned_floor_area_heated_cooled', floor_area), 'ft^2', 'm^2').get elsif floor_area_type == 'Heated Only' @conditioned_floor_area_heated_only = OpenStudio.convert(validate_positive_number_excluding_zero('@heated_only_floor_area', floor_area), 'ft^2', 'm^2').get From 05d32d9c7fb74b04892b595b3116e9aef15088ea Mon Sep 17 00:00:00 2001 From: kflemin Date: Fri, 10 Sep 2021 13:47:40 -0600 Subject: [PATCH 2/2] fix overwrite --- lib/buildingsync/model_articulation/spatial_element.rb | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/buildingsync/model_articulation/spatial_element.rb b/lib/buildingsync/model_articulation/spatial_element.rb index d699abf7..59c24e7c 100644 --- a/lib/buildingsync/model_articulation/spatial_element.rb +++ b/lib/buildingsync/model_articulation/spatial_element.rb @@ -67,7 +67,7 @@ def initialize(base_xml, ns) @space_types_floor_area = nil @conditioned_floor_area_heated_only = nil @conditioned_floor_area_cooled_only = nil - @conditioned_floor_area_heated_cooled = nil + @conditioned_floor_area_heated_cooled = 0 @custom_conditioned_above_grade_floor_area = nil @custom_conditioned_below_grade_floor_area = nil @@ -85,12 +85,10 @@ def read_floor_areas(parent_total_floor_area) floor_area_type = floor_area_element.elements["#{@ns}:FloorAreaType"].text if floor_area_type == 'Gross' @total_floor_area = OpenStudio.convert(validate_positive_number_excluding_zero('gross_floor_area', floor_area), 'ft^2', 'm^2').get - elsif floor_area_type == 'Heated and Cooled' - @conditioned_floor_area_heated_cooled = OpenStudio.convert(validate_positive_number_excluding_zero('@heated_and_cooled_floor_area', floor_area), 'ft^2', 'm^2').get elsif floor_area_type == 'Footprint' @footprint_floor_area = OpenStudio.convert(validate_positive_number_excluding_zero('@footprint_floor_area', floor_area), 'ft^2', 'm^2').get - elsif floor_area_type == 'Conditioned' || floor_area_type == 'Common' - @conditioned_floor_area_heated_cooled = OpenStudio.convert(validate_positive_number_excluding_zero('@conditioned_floor_area_heated_cooled', floor_area), 'ft^2', 'm^2').get + elsif floor_area_type == 'Conditioned' || floor_area_type == 'Common' || floor_area_type == 'Heated and Cooled' + @conditioned_floor_area_heated_cooled += OpenStudio.convert(validate_positive_number_excluding_zero('@conditioned_floor_area_heated_cooled', floor_area), 'ft^2', 'm^2').get elsif floor_area_type == 'Heated Only' @conditioned_floor_area_heated_only = OpenStudio.convert(validate_positive_number_excluding_zero('@heated_only_floor_area', floor_area), 'ft^2', 'm^2').get elsif floor_area_type == 'Cooled Only'