From aa7ac34722220d7ce5f3dea9511532934fe96faf Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Fri, 18 Nov 2022 22:41:07 +0000 Subject: [PATCH] vuln-fix: Temporary File Information Disclosure This fixes temporary file information disclosure vulnerability due to the use of the vulnerable `File.createTempFile()` method. The vulnerability is fixed by using the `Files.createTempFile()` method which sets the correct posix permissions. Weakness: CWE-377: Insecure Temporary File Severity: Medium CVSSS: 5.5 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.SecureTempFileCreation) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/18 Co-authored-by: Moderne --- .../org/apache/maven/shared/project/utils/ScmUtilsTest.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/test/java/org/apache/maven/shared/project/utils/ScmUtilsTest.java b/src/test/java/org/apache/maven/shared/project/utils/ScmUtilsTest.java index 1c5b602..1cb9643 100644 --- a/src/test/java/org/apache/maven/shared/project/utils/ScmUtilsTest.java +++ b/src/test/java/org/apache/maven/shared/project/utils/ScmUtilsTest.java @@ -24,6 +24,7 @@ import java.io.File; import java.io.IOException; +import java.nio.file.Files; import java.util.Collections; import org.apache.maven.model.Model; @@ -59,7 +60,7 @@ public void resolveScmConnectionByParent() Model parentModel = mock( Model.class ); when( parentModel.getModules() ).thenReturn( Collections.singletonList( "module" ) ); when( parent.getModel() ).thenReturn( parentModel ); - File parentBasedir = File.createTempFile( "tmpBasedir", null ); + File parentBasedir = Files.createTempFile( "tmpBasedir", null ).toFile(); when( parent.getBasedir() ).thenReturn( parentBasedir ); MavenProject project = mock( MavenProject.class ); @@ -85,7 +86,7 @@ public void resolveScmDeveloperConnectionByParent() Model parentModel = mock( Model.class ); when( parentModel.getModules() ).thenReturn( Collections.singletonList( "module" ) ); when( parent.getModel() ).thenReturn( parentModel ); - File parentBasedir = File.createTempFile( "tmpBasedir", null ); + File parentBasedir = Files.createTempFile( "tmpBasedir", null ).toFile(); when( parent.getBasedir() ).thenReturn( parentBasedir ); MavenProject project = mock( MavenProject.class );