You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I want to mention two issues I faced while using react-papaparse:
Poor TypeScript type inference on children render function arguments and prop types for CSVReader component.
Too many any type definition, unnecessary CSSProperties type castings and style?: any usages.
I have a fix proposal which includes updating useCSVReader by rewriting many props and type definitions and refactoring all the use cases regarding those updates. Also, updating examples on styling the CSVReader and removing style type castings.
With this properly typed CSVReader component and useCSVReader hook, the component itself and its render children function have proper type inference. Many unnecessary explicit type definitions can be removed. This way typescript support is meaningful since there are no more any type usage in returned component from the useCSVReader hook.
The text was updated successfully, but these errors were encountered:
Generic element types (HTMLDivElement or HTMLButtonElement) used for root and clickable remove elements which allow getRemoveFileProps and getRootProps to be properly types are added for useCSVReader.
Return types are updated for the hook, ProgressBar and Remove components as ComponentType which allows proper prop intellisense while using the components.
Event handler functions are generically typed using that generic element type for proper event handler types and event types. No more explicit event type definition is required.
ParseResult fn is updated so result is properly typed. Its object attributes can now be viewed using intellisense.
#150 includes further explanation and screenshots of fixed things and shows usage.
I want to mention two issues I faced while using react-papaparse:
CSVReader
component.any
type definition, unnecessaryCSSProperties
type castings andstyle?: any
usages.I have a fix proposal which includes updating useCSVReader by rewriting many props and type definitions and refactoring all the use cases regarding those updates. Also, updating examples on styling the CSVReader and removing style type castings.
With this properly typed
CSVReader
component anduseCSVReader
hook, the component itself and its render children function have proper type inference. Many unnecessary explicit type definitions can be removed. This way typescript support is meaningful since there are no moreany
type usage in returned component from theuseCSVReader
hook.The text was updated successfully, but these errors were encountered: