You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the implementation of ConnectionPool::create calls to_string on the password argument Option<&str>. From the perspective of the caller, working with lifetimes for the password only to have it be converted to a String anyway, seems not to be worth it. I suggest changing the password argument to be Option<String>. Thanks!
The text was updated successfully, but these errors were encountered:
Currently, the implementation of
ConnectionPool::create
callsto_string
on the password argumentOption<&str>
. From the perspective of the caller, working with lifetimes for the password only to have it be converted to a String anyway, seems not to be worth it. I suggest changing the password argument to beOption<String>
. Thanks!The text was updated successfully, but these errors were encountered: