Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pprof endpoints #103

Open
brancz opened this issue Mar 22, 2021 · 6 comments
Open

pprof endpoints #103

brancz opened this issue Mar 22, 2021 · 6 comments

Comments

@brancz
Copy link

brancz commented Mar 22, 2021

Hey 👋

We'd love to use emojivoto as an example workload in @polarsignals. To produce some data for Polar Signals Continuous Profiler we'de love to add pprof endpoints to each of the components. Would you be open to us adding the pprof endpoints in a similar manner as the prometheus endpoint? If you prefer we can also generalize them into a single "telemetry" port.

Let me know what you think, we're happy to take care of it!

@olix0r
Copy link
Member

olix0r commented Mar 22, 2021

@brancz This sounds like a great addition! We'd welcome this change.

+1 to serving these endpoints on a separate admin server if they're not already

@brancz
Copy link
Author

brancz commented Mar 22, 2021

There is already the PROM_PORT. I would propose to rename it to TELEMETRY_PORT and serve both the prometheus and the pprof endpoints under it, but don't feel strongly about it whatsoever, so if you prefer a separate PPROF_PORT, I'm totally ok with that as well.

@olix0r
Copy link
Member

olix0r commented Mar 22, 2021

@brancz Yeah, let's unify it as either TELEMETRY_PORT or ADMIN_PORT. Thanks!

@brancz
Copy link
Author

brancz commented Mar 22, 2021

Sounds good!

@brancz
Copy link
Author

brancz commented Mar 23, 2021

I started working on this, but I think I have mismatching versions of protoc and plugins from what this is built with. Do you mind if I update things to the latest version or let me know which version is being used to build this?

@alpeb
Copy link
Member

alpeb commented Mar 23, 2021

Thanks @brancz, upgrading to the latest protoc version sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants